Remove explicit Box::new
calls in memory mapping
#34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the syntax for defining a memory map much less verbose.
Old:
New:
This applies to Banked and Branch memory types.
This is accomplished by using
impl
syntax, replacingmemory: Box<dyn Memory>
withmemory: impl Memory + 'static
and constructing theBox
within the.bank
and.map
functions. The'static
is needed to ensure the Box's contents live long enough.